Use Aliasing API #2503
Open
Use Aliasing API #2503
+169
−110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ranocha
reviewed
Oct 27, 2024
jClugstor
force-pushed
the
AliasingAPI
branch
from
62b60f1 to
d05bb41
Compare
jClugstor
force-pushed
the
AliasingAPI
branch
from
0d07625 to
bdaa141
Compare
|
This just needs to use to use the version of SciMLBase with the AliasSpecifiers once that's released, then it should work and pass tests. |
lib/OrdinaryDiffEqCore/src/solve.jl
Outdated
Comment on lines
188
to
193
| # If alias isa Bool, all fields of ODEAliases set to alias | ||
| if alias isa Bool | ||
| aliases = ODEAliasSpecifier(alias = alias) | ||
| elseif isnothing(alias) || alias isa ODEAliasSpecifier | ||
| aliases = alias | ||
| end |
There was a problem hiding this comment.
Canonicalize this in the DifEqBase part?
There was a problem hiding this comment.
I'm not sure what you mean. This is here so that if alias = true or alias = false in solve that gets passed to the ODEAliasSpecifier constructor so that every variable is aliased / not aliased.
|
Oh yeah, this will require a release of DiffEqBase so that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
This makes use of the Aliasing API in SciMLBase SciML/SciMLBase.jl#830
The default of
alias_u0is preserved here, and it isn't breaking because it still respects whenalias_u0is put in as a kwarg to solve.