Allow configuration of the initialization done after interpolation while applying an affect #2507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ | |||
| # Hence, we need to have two separate functions. | |||
|
|
|||
| function _change_t_via_interpolation!(integrator, t, | |||
| modify_save_endpoint::Type{Val{T}}) where {T} | |||
| modify_save_endpoint::Type{Val{T}}, reinitialization_method=nothing) where {T} | |||
There was a problem hiding this comment.
Suggested change
| modify_save_endpoint::Type{Val{T}}, reinitialization_method=nothing) where {T} | |
| modify_save_endpoint::Type{Val{T}}, initialize_alg=nothing) where {T} |
There was a problem hiding this comment.
either this or callback_initializealg? The choice here doesn't follow the naming conventions or the other names.
There was a problem hiding this comment.
How about reinitalize_alg? I'm not super happy with simply calling it initialize_alg because it doesn't answer the question of "why does something that occurs mid-solve need to do initialization?" While "reinitialize" doesn't capture that super clearly, I think it's more obvious then just initialize_alg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Part of SciML/DiffEqBase.jl#1102 and SciML/SciMLBase.jl#842