refactor: generalize _initialize_dae! to use SciMLBase implementations
#2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
make sure to bump the lower bound of SciMLBase |
|
This PR needs SciML/SciMLBase.jl#857 to merge first, which is why I didn't bump any compat |
5 tasks
AayushSabharwal
force-pushed
the
as/rework-init
branch
from
0a66033 to
fad1752
Compare
ChrisRackauckas
approved these changes
Nov 19, 2024
|
Test failures. |
AayushSabharwal
force-pushed
the
as/rework-init
branch
from
fad1752 to
349bfcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.