fix: do not assume AbstractVectorOfArray is mutable in Base.zero

SciML · Oct 30, 2024 · 08e2d13 · 08e2d13
1 parent 600a9b5
commit 08e2d13
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/vector_of_array.jl b/src/vector_of_array.jl
@@ -521,7 +521,7 @@ end
 
 function Base.zero(VA::AbstractVectorOfArray)
     val = copy(VA)
-    val.u = zero.(VA.u)
+    val.u .= zero.(VA.u)
     return val
 end
 

diff --git a/test/interface_tests.jl b/test/interface_tests.jl
@@ -269,3 +269,13 @@ end
 f3!(z, zz)
 @test z == VectorOfArray([fill(4, SVector{2, Float64}), fill(2, SVector{2, Float64})])
 @test (@allocated f3!(z, zz)) == 0
+
+struct ImmutableVectorOfArray{T, N, A} <: AbstractVectorOfArray{T, N, A}
+    u::A # A <: AbstractArray{<: AbstractArray{T, N - 1}}
+end
+
+@testset "Base.zero does not assume mutable struct" begin
+    voa = ImmutableVectorOfArray{Float64, 2, Vector{Vector{Float64}}}([ones(3), 2ones(3)])
+    zvoa = zero(voa)
+    @test voa.u[1] == voa.u[2] == zeros(3)
+end