Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix views with boolean mask #335

Merged
merged 1 commit into from
Jan 17, 2024
Merged

fix: fix views with boolean mask #335

merged 1 commit into from
Jan 17, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal mentioned this pull request Jan 17, 2024
Closed
@ChrisRackauckas
Copy link
Member

https://github.com/SciML/RecursiveArrayTools.jl/actions/runs/7552002621/job/20560141714?pr=335#step:6:1512 😅

@AayushSabharwal
Copy link
Member Author

Yeah so that seems to be both an issue with DiffEqBase downstream test (ensemble_ad) using linear indexing and the linear indexing adjoint being a little broken

@ChrisRackauckas ChrisRackauckas merged commit 8bca0e9 into SciML:master Jan 17, 2024
16 of 18 checks passed
@AayushSabharwal AayushSabharwal deleted the as/bool-view branch January 17, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AayushSabharwal @ChrisRackauckas