Merge pull request #107 from SciML/sol_dims

fix dimensionality of sensitivity_solution
SciML · Oct 7, 2021 · 8941525 · 8941525
2 parents ccaba96 + 8a036f9
commit 8941525
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/src/solutions/nonlinear_solutions.jl b/src/solutions/nonlinear_solutions.jl
@@ -32,7 +32,7 @@ end
 
 function sensitivity_solution(sol::AbstractNonlinearSolution,u)
   T = eltype(eltype(u))
-  N = length((size(sol.prob.u0)...,))
+  N = ndims(u)
 
   NonlinearSolution{T,N,typeof(u),typeof(sol.resid),
                     typeof(sol.prob),typeof(sol.alg),

diff --git a/src/solutions/ode_solutions.jl b/src/solutions/ode_solutions.jl
@@ -178,7 +178,7 @@ function solution_slice(sol::AbstractODESolution{T,N},I) where {T,N}
 
  function sensitivity_solution(sol::AbstractODESolution,u,t)
    T = eltype(eltype(u))
-   N = length((size(sol.prob.u0)..., length(u)))
+   N = length((size(u)..., length(u)))
    interp = if typeof(sol.interp) <: LinearInterpolation
      LinearInterpolation(t,u)
    elseif typeof(sol.interp) <: ConstantInterpolation

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -3,7 +3,8 @@ using SafeTestsets
 using Test
 using SciMLBase
 
-@test isempty(detect_ambiguities(SciMLBase))
+# https://github.com/JuliaArrays/FillArrays.jl/pull/163
+@test_broken isempty(detect_ambiguities(SciMLBase))
 
 const GROUP = get(ENV, "GROUP", "All")
 const is_APPVEYOR = ( Sys.iswindows() && haskey(ENV,"APPVEYOR") )