Allow twopoint to be a Val

SciML · Oct 2, 2023 · a12a4fc · a12a4fc
1 parent d08f3f7
commit a12a4fc
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/src/problems/bvp_problems.jl b/src/problems/bvp_problems.jl
@@ -144,15 +144,17 @@ end
 # But we need it for function calls like TwoPointBVProblem{iip}(...) = ...
 struct TwoPointBVPFunction{iip} end
 
-@inline TwoPointBVPFunction(args...; kwargs...) = BVPFunction(args...; kwargs..., twopoint=true)
+@inline function TwoPointBVPFunction(args...; kwargs...)
+    return BVPFunction(args...; kwargs..., twopoint = Val(true))
+end
 @inline function TwoPointBVPFunction{iip}(args...; kwargs...) where {iip}
-    return BVPFunction{iip}(args...; kwargs..., twopoint=true)
+    return BVPFunction{iip}(args...; kwargs..., twopoint = Val(true))
 end
 
 function TwoPointBVProblem{iip}(f, bc, u0, tspan, p = NullParameters();
     bcresid_prototype=nothing, kwargs...) where {iip}
-    return TwoPointBVProblem(TwoPointBVPFunction{iip}(f, bc; bcresid_prototype), u0, tspan, p;
-        kwargs...)
+    return TwoPointBVProblem(TwoPointBVPFunction{iip}(f, bc; bcresid_prototype), u0, tspan,
+        p; kwargs...)
 end
 function TwoPointBVProblem(f, bc, u0, tspan, p = NullParameters();
     bcresid_prototype=nothing, kwargs...)

diff --git a/src/scimlfunctions.jl b/src/scimlfunctions.jl
@@ -4064,12 +4064,13 @@ function BVPFunction{iip, specialize, twopoint}(f, bc;
     end
 end
 
-function BVPFunction{iip}(f, bc; twopoint::Bool=false, kwargs...) where {iip}
-    BVPFunction{iip, FullSpecialize, twopoint}(f, bc; kwargs...)
+function BVPFunction{iip}(f, bc; twopoint::Union{Val, Bool}=Val(false),
+    kwargs...) where {iip}
+    BVPFunction{iip, FullSpecialize, _unwrap_val(twopoint)}(f, bc; kwargs...)
 end
 BVPFunction{iip}(f::BVPFunction, bc; kwargs...) where {iip} = f
-function BVPFunction(f, bc; twopoint::Bool=false, kwargs...)
-    BVPFunction{isinplace(f, 4), FullSpecialize, twopoint}(f, bc; kwargs...)
+function BVPFunction(f, bc; twopoint::Union{Val, Bool}=Val(false), kwargs...)
+    BVPFunction{isinplace(f, 4), FullSpecialize, _unwrap_val(twopoint)}(f, bc; kwargs...)
 end
 BVPFunction(f::BVPFunction; kwargs...) = f