Merge pull request #625 from oscardssmith/os/reeval_internals-improve…

…ments add optional `continuous_modification` argument to `reeval_internals_due_to_modification!`
SciML · Feb 14, 2024 · eca78b8 · eca78b8
2 parents f457edc + 3ef766a
commit eca78b8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "SciMLBase"
 uuid = "0bca4576-84f4-4d90-8ffe-ffa030f20462"
 authors = ["Chris Rackauckas <[email protected]> and contributors"]
-version = "2.25.0"
+version = "2.26.0"
 
 [deps]
 ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b"

diff --git a/src/integrator_interface.jl b/src/integrator_interface.jl
@@ -313,10 +313,16 @@ end
 addsteps!(i::DEIntegrator, args...) = nothing
 
 """
-    reeval_internals_due_to_modification!(integrator::DDEIntegrator)
+    reeval_internals_due_to_modification!(integrator::DEIntegrator, continuous_modification=true)
 
-Recalculate interpolation data and update ODE integrator after changes by callbacks.
+Update DE integrator after changes by callbacks.
+For DAEs (either implicit or semi-explicit), this requires re-solving alebraic variables.
+If continuous_modification is true (or unspecified), this should also recalculate interpolation data.
+Otherwise the integrator is allowed to skip recalculating the interpolation.
 """
+function reeval_internals_due_to_modification!(integrator::DEIntegrator, continuous_modification)
+    reeval_internals_due_to_modification!(integrator::DEIntegrator)
+end
 reeval_internals_due_to_modification!(integrator::DEIntegrator) = nothing
 
 """