Skip to content

Commit

Permalink
fixup! fix: fix remake for symbolic indexing, add tests for remake
Browse files Browse the repository at this point in the history
  • Loading branch information
AayushSabharwal committed Mar 8, 2024
1 parent 865453f commit f3aad42
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/remake.jl
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,8 @@ function updated_p(prob, p; interpret_symbolicmap = true)
return p

Check warning on line 401 in src/remake.jl

View check run for this annotation

Codecov / codecov/patch

src/remake.jl#L401

Added line #L401 was not covered by tests
end
p = Dict(p)
elseif SciMLStructures.isscimlstructure(p) || p isa Union{AbstractArray, Tuple} || typeof(p) === typeof(parameter_values(prob))
return p
else
throw(ArgumentError("Invalid value for p: $p. Must be an array of appropriate length, a symbolic map, or a SciMLStructure."))
return p
end

newp = copy(parameter_values(prob))
Expand Down

0 comments on commit f3aad42

Please sign in to comment.