Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DynamicalSDEFunction and Problem #21

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Add DynamicalSDEFunction and Problem #21

merged 1 commit into from
Feb 6, 2021

Conversation

jamesgardner1421
Copy link
Contributor

I've added the DynamicalSDEProblem and DynamicalSDEFunction. I'm not entirely sure if these are necessary since they're almost direct copies of the existing SplitSDEProblem/Function.

The reason for this PR is for #259 in StochasticDiffEq. I've also submitted a PR to StochasticDiffEq that uses these functions with the BAOAB algorithm.

I don't understand the existence of the SplitSDEProblem type since its constructors just create the original SDEProblem instead, so as far as I can tell, the SplitSDEProblem itself is never used. I followed this trend for the new DynamicalSDEProblem but perhaps it's not necessary.

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #21 (4d17fce) into master (dbcf70f) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #21      +/-   ##
=========================================
- Coverage    2.87%   2.85%   -0.03%     
=========================================
  Files          37      37              
  Lines        2712    2734      +22     
=========================================
  Hits           78      78              
- Misses       2634    2656      +22     
Impacted Files Coverage Δ
src/SciMLBase.jl 50.00% <ø> (ø)
src/problems/sde_problems.jl 0.00% <0.00%> (ø)
src/scimlfunctions.jl 2.88% <0.00%> (-0.05%) ⬇️
src/solutions/solution_interface.jl 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbcf70f...4d17fce. Read the comment docs.

@ChrisRackauckas ChrisRackauckas merged commit a409c3d into SciML:master Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants