Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Value type requirement from SampledIntegralProblem #498

Merged
merged 3 commits into from
Sep 20, 2023
Merged

remove Value type requirement from SampledIntegralProblem #498

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac73376
remove Value type requirement from SampledIntegralProblem
IlianPihlajamaa Sep 18, 2023
819ec92
Update src/problems/basic_problems.jl
ChrisRackauckas Sep 19, 2023
d70980e
Update basic_problems.jl
ChrisRackauckas Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/problems/basic_problems.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,18 +426,18 @@ SampledIntegralProblem(y::AbstractArray, x::AbstractVector; dim=ndims(y), kwargs

The fields match the names of the constructor arguments.
"""
struct SampledIntegralProblem{Y, X, D, K} <: AbstractIntegralProblem{false}
struct SampledIntegralProblem{Y, X, K} <: AbstractIntegralProblem{false}
y::Y
x::X
dim::D
dim::Int
kwargs::K
@add_kwonly function SampledIntegralProblem(y::AbstractArray, x::AbstractVector;
dim = ndims(y),
kwargs...)
@assert dim <= ndims(y) "The integration dimension `dim` is larger than the number of dimensions of the integrand `y`"
@assert length(x)==size(y, dim) "The integrand `y` must have the same length as the sampling points `x` along the integrated dimension."
@assert axes(x, 1)==axes(y, dim) "The integrand `y` must obey the same indexing as the sampling points `x` along the integrated dimension."
new{typeof(y), typeof(x), Val{dim}, typeof(kwargs)}(y, x, Val(dim), kwargs)
new{typeof(y), typeof(x), typeof(kwargs)}(y, x, dim, kwargs)
end
end

Expand Down
Loading