Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print return code for NonTimeseries Solutions as well #545

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

avik-pal
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (a0a5505) 41.86% compared to head (912f3ca) 41.82%.

Files Patch % Lines
src/solutions/solution_interface.jl 0.00% 4 Missing ⚠️
src/solutions/nonlinear_solutions.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
- Coverage   41.86%   41.82%   -0.05%     
==========================================
  Files          53       53              
  Lines        4151     4155       +4     
==========================================
  Hits         1738     1738              
- Misses       2413     2417       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Does every solution type have a retcode?

@avik-pal
Copy link
Member Author

Good point, I am conditionally printing it if available

@ChrisRackauckas ChrisRackauckas merged commit 82d6c62 into master Nov 24, 2023
36 of 40 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/print_retcode branch November 24, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants