Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for new symbol indexing methods in SII #571

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Dec 27, 2023

Requires SciML/SymbolicIndexingInterface.jl#18

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (f17b506) 30.50% compared to head (1bdb65c) 30.42%.

Files Patch % Lines
src/integrator_interface.jl 0.00% 12 Missing ⚠️
src/solutions/ode_solutions.jl 0.00% 9 Missing ⚠️
src/problems/problem_interface.jl 0.00% 6 Missing ⚠️
src/solutions/solution_interface.jl 0.00% 5 Missing ⚠️
ext/SciMLBaseZygoteExt.jl 0.00% 2 Missing ⚠️
src/ensemble/ensemble_solutions.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #571      +/-   ##
==========================================
- Coverage   30.50%   30.42%   -0.09%     
==========================================
  Files          53       53              
  Lines        4019     4030      +11     
==========================================
  Hits         1226     1226              
- Misses       2793     2804      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal
Copy link
Member Author

CI won't pass, because it depends on MTK

@AayushSabharwal
Copy link
Member Author

cjdoris/julia-downgrade-compat-action@v1 is pinning stdlib dependencies too, so it doesn't resolve on versions other than 1.9

@ChrisRackauckas
Copy link
Member

okay, we'll bump to v1.10 soon. Ignore for now

@ChrisRackauckas ChrisRackauckas merged commit 1b995b6 into SciML:master Dec 28, 2023
30 of 41 checks passed
@AayushSabharwal AayushSabharwal deleted the as/tests branch December 28, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants