[WIP]Allow state and iterations as arguments in callback #573
Conversation
| using them for plotting and display without recalculating. The callback should | ||
| return a Boolean value, and the default should be `false`, such that the optimization | ||
| gets stopped if it returns `true`. | ||
| the optimization `f` or the state of the optimizer and iteration count. This allows |
There was a problem hiding this comment.
" or the state of the optimizer and iteration count" what do you mean by that?
There was a problem hiding this comment.
I'll refine it. It's a placeholder to make sure I update it as soon as the update happens in the wrappers.
The point is that the callback will have a current state of the optimizer if it's available and iteration counts
There was a problem hiding this comment.
I don't understand how that would work. Wouldn't that need to be an argument? If so, how is that argument uniformized? I don't see a struct definition or docs to go along with that.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
===========================================
+ Coverage 5.26% 30.49% +25.22%
===========================================
Files 53 53
Lines 4061 4020 -41
===========================================
+ Hits 214 1226 +1012
+ Misses 3847 2794 -1053 ☔ View full report in Codecov by Sentry. |
This needs the solver wrappers other than OptimizationOptimisers to have it implemented