-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for ParameterIndexingProxy #584
feat: add support for ParameterIndexingProxy #584
Conversation
ad1e627
to
4e71414
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #584 +/- ##
==========================================
+ Coverage 30.43% 30.48% +0.04%
==========================================
Files 53 54 +1
Lines 4045 4068 +23
==========================================
+ Hits 1231 1240 +9
- Misses 2814 2828 +14 ☔ View full report in Codecov by Sentry. |
4e71414
to
17e3481
Compare
No, a badly written test I think 😅 |
548b9d5
to
7242d6e
Compare
Requires https://github.com/SciML/SymbolicIndexingInterface.jl to be merged and tagged |
7242d6e
to
bc4057c
Compare
All SciMLSensitivity tests just started failing? https://github.com/SciML/SciMLBase.jl/actions/runs/7567194901/job/20605897599?pr=584#step:6:1328 @AayushSabharwal was this something form RAT? |
Yep. It doesn't like some of the adjoints again. |
Can you yank that last release? |
SciMLSensitivity won't pass until after SciML/RecursiveArrayTools.jl#337 |
bc4057c
to
e25f46d
Compare
@AayushSabharwal make sure to follow up on the JumpProcesses.jl downstream. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.