Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ParameterIndexingProxy #584

Merged

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member Author

Requires SciML/SymbolicIndexingInterface.jl#26

@AayushSabharwal AayushSabharwal force-pushed the as/parameter-indexing-proxy branch from ad1e627 to 4e71414 Compare January 5, 2024 11:18
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (8188851) 30.43% compared to head (e25f46d) 30.48%.
Report is 6 commits behind head on master.

Files Patch % Lines
src/problems/basic_problems.jl 0.00% 2 Missing ⚠️
src/problems/problem_interface.jl 60.00% 2 Missing ⚠️
src/solutions/optimization_solutions.jl 0.00% 2 Missing ⚠️
src/integrator_interface.jl 50.00% 1 Missing ⚠️
src/solutions/dae_solutions.jl 50.00% 1 Missing ⚠️
src/solutions/ode_solutions.jl 50.00% 1 Missing ⚠️
src/solutions/rode_solutions.jl 50.00% 1 Missing ⚠️
src/solutions/solution_interface.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #584      +/-   ##
==========================================
+ Coverage   30.43%   30.48%   +0.04%     
==========================================
  Files          53       54       +1     
  Lines        4045     4068      +23     
==========================================
+ Hits         1231     1240       +9     
- Misses       2814     2828      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal AayushSabharwal force-pushed the as/parameter-indexing-proxy branch from 4e71414 to 17e3481 Compare January 5, 2024 12:34
@ChrisRackauckas
Copy link
Member

@AayushSabharwal
Copy link
Member Author

No, a badly written test I think 😅

@AayushSabharwal AayushSabharwal force-pushed the as/parameter-indexing-proxy branch from 548b9d5 to 7242d6e Compare January 9, 2024 14:05
@AayushSabharwal
Copy link
Member Author

Requires https://github.com/SciML/SymbolicIndexingInterface.jl to be merged and tagged

@AayushSabharwal AayushSabharwal force-pushed the as/parameter-indexing-proxy branch from 7242d6e to bc4057c Compare January 18, 2024 08:22
@ChrisRackauckas
Copy link
Member

All SciMLSensitivity tests just started failing? https://github.com/SciML/SciMLBase.jl/actions/runs/7567194901/job/20605897599?pr=584#step:6:1328 @AayushSabharwal was this something form RAT?

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Jan 18, 2024

Yep. It doesn't like some of the adjoints again. Why did I ever touch them

@ChrisRackauckas
Copy link
Member

Can you yank that last release?

@AayushSabharwal
Copy link
Member Author

SciMLSensitivity won't pass until after SciML/RecursiveArrayTools.jl#337

@AayushSabharwal AayushSabharwal force-pushed the as/parameter-indexing-proxy branch from bc4057c to e25f46d Compare January 24, 2024 07:32
@ChrisRackauckas ChrisRackauckas merged commit df27cdc into SciML:master Jan 24, 2024
31 of 41 checks passed
@ChrisRackauckas
Copy link
Member

@AayushSabharwal make sure to follow up on the JumpProcesses.jl downstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants