Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move OptimizationStats to SciMLBase #600

Merged
merged 2 commits into from
Jan 18, 2024
Merged

Move OptimizationStats to SciMLBase #600

merged 2 commits into from
Jan 18, 2024

Conversation

Vaibhavdixit02
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

end
end

TruncatedStacktraces.@truncate_stacktrace OptimizationProblem 1 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a cleanup, @avik-pal we should start removing this wherever we see it

@ChrisRackauckas
Copy link
Member

Test failures 😓

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (bc92540) 30.43% compared to head (0f8bb02) 30.40%.
Report is 13 commits behind head on master.

Files Patch % Lines
src/problems/optimization_problems.jl 47.61% 11 Missing ⚠️
src/solutions/optimization_solutions.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #600      +/-   ##
==========================================
- Coverage   30.43%   30.40%   -0.04%     
==========================================
  Files          53       54       +1     
  Lines        4045     4049       +4     
==========================================
  Hits         1231     1231              
- Misses       2814     2818       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit a9d6399 into master Jan 18, 2024
31 of 42 checks passed
@ChrisRackauckas ChrisRackauckas deleted the statsmove branch January 18, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants