Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: implement two-argument SII.parameter_values #616

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (aaa8718) 38.87% compared to head (9277b8d) 38.86%.
Report is 2 commits behind head on master.

Files Patch % Lines
src/solutions/solution_interface.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
- Coverage   38.87%   38.86%   -0.01%     
==========================================
  Files          55       55              
  Lines        4270     4271       +1     
==========================================
  Hits         1660     1660              
- Misses       2610     2611       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit d247cbf into SciML:master Feb 9, 2024
30 of 41 checks passed
@AayushSabharwal AayushSabharwal deleted the as/getp-generic branch February 9, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants