Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare condition functions #623

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

LilithHafner
Copy link
Member

@LilithHafner LilithHafner commented Feb 13, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes SciML/diffeqpy#136.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (0475fc3) 38.81% compared to head (4bfb5bf) 26.38%.

Files Patch % Lines
src/callbacks.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #623       +/-   ##
===========================================
- Coverage   38.81%   26.38%   -12.44%     
===========================================
  Files          55       55               
  Lines        4261     4249       -12     
===========================================
- Hits         1654     1121      -533     
- Misses       2607     3128      +521     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit b9e368e into SciML:master Feb 14, 2024
25 of 42 checks passed
@LilithHafner LilithHafner deleted the lh/prepare-conditions branch February 14, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError on DiscreteCallback
2 participants