Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove usages of syms/paramsyms/indepsym keyword argument #624

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

AayushSabharwal
Copy link
Member

@AayushSabharwal AayushSabharwal commented Feb 14, 2024

Close #618

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0475fc3) 38.81% compared to head (8898aa2) 38.77%.

Files Patch % Lines
src/scimlfunctions.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
- Coverage   38.81%   38.77%   -0.05%     
==========================================
  Files          55       55              
  Lines        4261     4261              
==========================================
- Hits         1654     1652       -2     
- Misses       2607     2609       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 96f77c8 into SciML:master Feb 14, 2024
30 of 42 checks passed
@AayushSabharwal AayushSabharwal deleted the as/scimlfunction-sym branch February 14, 2024 11:46
@oscardssmith
Copy link
Contributor

isn't there still a lot of code that uses these fields if the sys is unavailable?

@ChrisRackauckas
Copy link
Member

Is there? I don't know of any at least. It should've been throwing warnings for at least a few months now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warning when converting SteadyStateProblem to NonlinearProblem
3 participants