Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test, docs: fix tests and docs for MTKv9 #634

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 37.54%. Comparing base (0998e07) to head (e5e1172).

Files Patch % Lines
src/scimlfunctions.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #634      +/-   ##
==========================================
+ Coverage   28.86%   37.54%   +8.67%     
==========================================
  Files          55       55              
  Lines        4285     4294       +9     
==========================================
+ Hits         1237     1612     +375     
+ Misses       3048     2682     -366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Feb 26, 2024

There are more fixes than it looks like there are, I'm working on this locally. MTK needs a couple changes to support indexing with Symbols (prob.ps[:a] to refer to @parameters a)

@ChrisRackauckas
Copy link
Member

Rebase this. I fixed some test cases

@AayushSabharwal
Copy link
Member Author

Requires the fix in SciML/ModelingToolkit.jl#2524

@ChrisRackauckas ChrisRackauckas merged commit 1ecb061 into SciML:master Mar 7, 2024
57 of 82 checks passed
@AayushSabharwal AayushSabharwal deleted the as/test-v9 branch March 7, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants