Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow integrand_prototype for oop integral functions #636

Merged
merged 4 commits into from
Feb 27, 2024

Conversation

lxvm
Copy link
Contributor

@lxvm lxvm commented Feb 26, 2024

Previously, IntegralFunction(f, integrand_prototype) would error for oop f and this pr makes it possible to pass an oop f because the integrand_prototype is still useful to infer the return type of f without evaluating it. Integral algorithms often need to have a prototype to have a correct wrapper so this will avoid additional integrand evaluations.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.19%. Comparing base (d45b79a) to head (263f910).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #636      +/-   ##
==========================================
- Coverage   26.26%   26.19%   -0.07%     
==========================================
  Files          55       55              
  Lines        4283     4279       -4     
==========================================
- Hits         1125     1121       -4     
  Misses       3158     3158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 400f292 into SciML:master Feb 27, 2024
33 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants