Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added trait constraints to solve.jl for calculation of gradients, hessians and more. #651

Closed
wants to merge 0 commits into from

Conversation

ParasPuneetSingh
Copy link
Contributor

Added checks for requiresgradient, requireshessian, requiresconsjac, and requiresconshess in __check_opt_alg function.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 4.94%. Comparing base (9fbff32) to head (79817b3).
Report is 42 commits behind head on master.

❗ Current head 79817b3 differs from pull request most recent head 8bd04a1. Consider uploading reports for the commit 8bd04a1 to get more accurate results

Files Patch % Lines
src/solve.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #651       +/-   ##
==========================================
- Coverage   38.49%   4.94%   -33.56%     
==========================================
  Files          55      55               
  Lines        4291    4250       -41     
==========================================
- Hits         1652     210     -1442     
- Misses       2639    4040     +1401     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Vaibhavdixit02 added a commit that referenced this pull request Apr 19, 2024
Changed trait constraints to solve.jl for calculation of gradients, hessians and more. #651
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant