Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix plotting analytic time series #655

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

ranocha
Copy link
Member

@ranocha ranocha commented Mar 22, 2024

Fixes SciML/OrdinaryDiffEq.jl#2162

The changes of this part of the code were introduced in https://github.com/SciML/SciMLBase.jl/pull/572/files

I also added some real (smoke) tests for this, including loading Plots.jl and generating some plots (maybe unicodeplots?).

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

It would be nice to get a new release including this fix.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 29.88%. Comparing base (3746cda) to head (f84c40e).

Files Patch % Lines
src/solutions/solution_interface.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
- Coverage   38.43%   29.88%   -8.56%     
==========================================
  Files          55       55              
  Lines        4298     4290       -8     
==========================================
- Hits         1652     1282     -370     
- Misses       2646     3008     +362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ranocha ranocha force-pushed the hr/fix_plot_analytic_timeseries branch from c1d2270 to f84c40e Compare March 22, 2024 08:50
@ChrisRackauckas ChrisRackauckas merged commit 1e6ed51 into SciML:master Mar 22, 2024
28 of 42 checks passed
@ranocha ranocha deleted the hr/fix_plot_analytic_timeseries branch March 22, 2024 11:32
@ranocha
Copy link
Member Author

ranocha commented Mar 22, 2024

Thanks! Could we maybe get a new release of SciMLBase.jl soon to fix our CI issues, please?

@ranocha ranocha mentioned this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotting analytic solutions fails
2 participants