fix: fix setindex! not erroring appropriately for integrators
#657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #657 +/- ##
==========================================
+ Coverage 30.03% 30.12% +0.09%
==========================================
Files 55 55
Lines 4309 4308 -1
==========================================
+ Hits 1294 1298 +4
+ Misses 3015 3010 -5 ☔ View full report in Codecov by Sentry. |
Comment on lines
380
to
381
| @test_throws ErrorException oint[X]=1.0 | ||
| @test_throws ErrorException setu(oint, X)(oint, 10.0) |
There was a problem hiding this comment.
There was a problem hiding this comment.
Changing out the u vector is different from mutating it. These functions should just mutate u.
AayushSabharwal
force-pushed
the
as/integrator-setindex-error
branch
from
0f2c5aa to
a07a002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #653
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.