Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix remake initialization with dependent default values #671

Merged

Conversation

AayushSabharwal
Copy link
Member

Close #648

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.80%. Comparing base (d947bed) to head (bf58889).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   40.55%   40.80%   +0.24%     
==========================================
  Files          55       55              
  Lines        4478     4490      +12     
==========================================
+ Hits         1816     1832      +16     
+ Misses       2662     2658       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 91ac9f9 into SciML:master Apr 16, 2024
35 of 42 checks passed
@AayushSabharwal AayushSabharwal deleted the as/remake-respect-dependencies branch April 16, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remake does not update parametric initial conditions
2 participants