autospecialize rather than full specialize by default for the various NonlinearProblems
#681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NonlinearProblems
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #681 +/- ##
==========================================
- Coverage 31.74% 31.67% -0.07%
==========================================
Files 55 55
Lines 4505 4508 +3
==========================================
- Hits 1430 1428 -2
- Misses 3075 3080 +5 ☔ View full report in Codecov by Sentry. |
|
might as well |
|
are you sure the CI failures here weren't real? They looked plausibly related |
|
They do seem related |
|
Revert |
|
I'm really confused how this was causing problems since from looking at the code, AutoSpecialize should only change things for in place ODEFunctions. |
ChrisRackauckas
added a commit
that referenced
this pull request
May 1, 2024
…onlinearFunctions revert #681 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change anything yet, but is a step in the direction of making NonlinearSolve not specialize on the user given function which will reduce compilation time on first nonlinear solve.