Chore: remove mentions of SDESolution #683
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
SDESolution
doesn't seem to exist anymore. The more appropriate type seems to beRODESolution
. This PR removes mentions of SDESolution and replaces them withRODESolution
. Further, one of the adjoints was incorrect. It was definining an adjoint over SDEProblem, but instead tries returning SDESolution in the forwards pass. Not sure how this passed tests thoughAdd any other context about the problem here.