-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve dtmin and unstable detection #693
improve dtmin and unstable detection #693
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #693 +/- ##
===========================================
- Coverage 41.40% 29.31% -12.10%
===========================================
Files 55 55
Lines 4557 4551 -6
===========================================
- Hits 1887 1334 -553
- Misses 2670 3217 +547 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Christopher Rackauckas <[email protected]>
Re-running CI (now that it's morning so codecov will hopefully be happier and now that the OrdinaryDiffEq test that I think was the only real failure is fixed). |
Followup to #692. It turns out that OrdinaryDiffEq sets the minimum dt to
eps(t)
which is relatively sensible, but that means that we should be failing with an error if we don't accept a step and we're already at the minimum dt.This definitely needs some tests, but I think those tests need to be in OrdinaryDiffEq so they will be added as a separate PR once this merges.