Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make nonlinear problem mutable #708

Merged

Conversation

m-bossart
Copy link
Contributor

Makes NonlinearProblem mutable in order to enable Enzyme compatibility (SciML/NonlinearSolve.jl#439)

@m-bossart m-bossart marked this pull request as ready for review June 8, 2024 19:56
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.34%. Comparing base (79c1b04) to head (5146f38).

Files Patch % Lines
src/problems/basic_problems.jl 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   41.39%   41.34%   -0.06%     
==========================================
  Files          55       55              
  Lines        4626     4632       +6     
==========================================
  Hits         1915     1915              
- Misses       2711     2717       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit c312fd8 into SciML:master Jun 9, 2024
28 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants