Add MaxNumSub return code #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+155
to
+163
| A failure exit state of the solver. If this return code is given, then the | ||
| solving process was unsuccessful and exited early because during the solver's | ||
| adaptivity, mesh length exceeded the `max_num_subintervals` either set by default or specified | ||
| by users in the solver. | ||
|
|
||
| ## Common Reasons for Seeing this Return Code | ||
|
|
||
| - This commonly occurs in BVP solving if the original mesh are too coarse or | ||
| the tolerance are too stringent. It is recommended that in such cases, one tries to increase the default `max_num_subintervals` |
There was a problem hiding this comment.
No, MaxIters is used for the exit because the default iteration number exceeded, say, number of Newton iterations, but for cases when solving ill-conditioned problems with adaptivity(we redistribute or halve the mesh), the mesh would become so large that we need to warn users instead of just throw Failure. Although the reasons for MaxIters and MaxNumSub are similar, tolerance is stringent or nonstiff solvers on stiff problems, etc, I believe these failure statuses are two different things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of SciML/BoundaryValueDiffEq.jl#257
Add
MaxNumSubreturn code to indicate the maximum number of subintervals are exceeded during the adaptivity process and throw proper warning