Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add infrastructure for initialization of different problem types #885

Merged
merged 30 commits into from
Dec 10, 2024

Conversation

AayushSabharwal
Copy link
Member

Requires SciML/SymbolicIndexingInterface.jl#109

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@AayushSabharwal AayushSabharwal marked this pull request as ready for review December 4, 2024 06:18
@AayushSabharwal AayushSabharwal changed the title [WIP] feat: add infrastructure for initialization of different problem types feat: add infrastructure for initialization of different problem types Dec 4, 2024
@AayushSabharwal
Copy link
Member Author

Requires SciML/ModelingToolkit.jl#3258 for testing

@AayushSabharwal AayushSabharwal force-pushed the as/init-infra branch 3 times, most recently from e62cf1e to 99baebd Compare December 9, 2024 08:20
@AayushSabharwal
Copy link
Member Author

Can the failing downstream test be changed to a <=? It passes locally, not yet sure why it fails CI

@ChrisRackauckas
Copy link
Member

Yeah that's fine. I guess you expect that on average it will go to a better local minima but it doesn't always... not a great test.

@ChrisRackauckas ChrisRackauckas merged commit f970ee7 into SciML:master Dec 10, 2024
14 of 24 checks passed
@AayushSabharwal AayushSabharwal deleted the as/init-infra branch December 11, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants