-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add infrastructure for initialization of different problem types #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
AayushSabharwal
force-pushed
the
as/init-infra
branch
from
December 4, 2024 06:18
2e9cb60
to
2572c56
Compare
AayushSabharwal
changed the title
[WIP] feat: add infrastructure for initialization of different problem types
feat: add infrastructure for initialization of different problem types
Dec 4, 2024
Requires SciML/ModelingToolkit.jl#3258 for testing |
AayushSabharwal
force-pushed
the
as/init-infra
branch
3 times, most recently
from
December 9, 2024 08:20
e62cf1e
to
99baebd
Compare
AayushSabharwal
force-pushed
the
as/init-infra
branch
from
December 9, 2024 11:11
99baebd
to
fbcc39e
Compare
5 tasks
AayushSabharwal
force-pushed
the
as/init-infra
branch
from
December 10, 2024 10:16
b183af9
to
9ecdae6
Compare
AayushSabharwal
force-pushed
the
as/init-infra
branch
from
December 10, 2024 12:11
9ecdae6
to
ee118ef
Compare
Can the failing downstream test be changed to a |
Yeah that's fine. I guess you expect that on average it will go to a better local minima but it doesn't always... not a great test. |
ChrisRackauckas
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires SciML/SymbolicIndexingInterface.jl#109
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.