Skip to content

Commit

Permalink
ci(buildkite): run builds on PRs opened from forks as well
Browse files Browse the repository at this point in the history
Previously, the buildkite jobs wouldn't launch for PRs that were opened
on forks, because the `smooth-checkout` plugin would not be able to find
a valid refspec[^1]. This fixes this up for the most general cases, i.e.,
when a build is kicked off because a PR is opened or more commits are
added on to the PR, and is not expected to work when builds are
explicitly triggered (through the Web UI) for the `HEAD` commit.

[^1]: https://buildkite.com/julialang/scimldocs/builds/3324#018cb654-71a9-4ce3-9af3-d7e21d044397/101-119
  • Loading branch information
thazhemadam committed Jan 30, 2024
1 parent ae39533 commit b36024f
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .buildkite/0_webui.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
steps:
- label: ":rocket: Launch Pipeline!"
plugins:
- hasura/smooth-checkout#v4.4.1:
repos:
- config:
- url: "https://github.com/SciML/SciMLDocs.git"
ref: "${BUILDKITE_COMMIT}"
clone_flags: "--depth=1"
- staticfloat/cryptic#v2:
signed_pipelines:
- pipeline: .buildkite/aggregate.yml
Expand Down
1 change: 1 addition & 0 deletions .buildkite/aggregate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ steps:
repos:
- config:
- url: "https://github.com/SciML/SciMLDocs.git"
ref: "${BUILDKITE_COMMIT}"
clone_flags: "--depth=1"

- staticfloat/cryptic#v2:
Expand Down
2 changes: 1 addition & 1 deletion .buildkite/aggregate.yml.signature
Original file line number Diff line number Diff line change
@@ -1 +1 @@
Salted__��CeNFm��A{2KJ�5���d0o\�D@D{]$�%���'i�X�j'|G�$�����9V���A�U]��7&y�0��q\{�W��k�7
Salted__f��Ǘ{/���qO�w����{�bx'0P���SM�����}K��f*�-7�,�I�QO|A&V���ňzQ��I�8RG�#
Expand Down
1 change: 1 addition & 0 deletions .buildkite/documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ steps:
repos:
- config:
- url: "https://github.com/SciML/SciMLDocs.git"
ref: "${BUILDKITE_COMMIT}"
clone_flags: "--depth=1"

command: |
Expand Down

0 comments on commit b36024f

Please sign in to comment.