Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Packages that are no longer needed in 1.10 #239

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Feb 26, 2024

After that entire discussion on slack regarding SimpleNonlinearSolve precompile times. It seems we are installing packages that are not needed in 1.10+.

This + some SciMLBase changes:

# OLD
julia> @time using SciMLOperators, SciMLBase
  0.137750 seconds (160.93 k allocations: 16.369 MiB)

# NEW
julia> @time using SciMLOperators, SciMLBase
  0.090675 seconds (113.75 k allocations: 13.515 MiB)

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.98%. Comparing base (b79f2e1) to head (0f21d64).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #239      +/-   ##
==========================================
- Coverage   68.17%   67.98%   -0.20%     
==========================================
  Files          10       10              
  Lines        1653     1643      -10     
==========================================
- Hits         1127     1117      -10     
  Misses        526      526              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 0cdfd8a into master Feb 26, 2024
12 of 13 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/deps branch February 26, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants