Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Test Failures #1033

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Fix Test Failures #1033

merged 3 commits into from
Mar 14, 2024

Conversation

avik-pal
Copy link
Member

No description provided.

@avik-pal
Copy link
Member Author

@frankschae for the diffeq test failure it seems like the reverselosscallback time is going down to 0 which is causing the indexing error.

_t = Float32[0.0, 0.062241733, 0.19261953, 0.44402307, 0.7661728, 1.0]
(cur_time, t) = (Base.RefValue{Int64}(6), Float32[0.0, 0.062241733, 0.19261953, 0.44402307, 0.7661728, 1.0])
(cur_time, t) = (Base.RefValue{Int64}(5), Float32[0.0, 0.062241733, 0.19261953, 0.44402307, 0.7661728, 1.0])
(cur_time, t) = (Base.RefValue{Int64}(4), Float32[0.0, 0.062241733, 0.19261953, 0.44402307, 0.7661728, 1.0])
(cur_time, t) = (Base.RefValue{Int64}(3), Float32[0.0, 0.062241733, 0.19261953, 0.44402307, 0.7661728, 1.0])
(cur_time, t) = (Base.RefValue{Int64}(2), Float32[0.0, 0.062241733, 0.19261953, 0.44402307, 0.7661728, 1.0])
(cur_time, t) = (Base.RefValue{Int64}(1), Float32[0.0, 0.062241733, 0.19261953, 0.44402307, 0.7661728, 1.0])
(cur_time, t) = (Base.RefValue{Int64}(0), Float32[0.0, 0.062241733, 0.19261953, 0.44402307, 0.7661728, 1.0])

@avik-pal avik-pal changed the title [WIP] Fix Test Failures Fix Test Failures Mar 12, 2024
@avik-pal
Copy link
Member Author

@ChrisRackauckas this handles the main failures we were seeing. The remaining in Core3 are from DAEs but all of the adjoint methods seem to fail there, not sure what caused that.

@frankschae
Copy link
Member

Do we know what change caused that? I think the last time that we got such an indexing error, it was save_positions not handled correctly.

@avik-pal
Copy link
Member Author

Not sure, the tests were not running for sometime it seems, it was activating an incorrect env

@avik-pal avik-pal merged commit 6e48a61 into master Mar 14, 2024
13 of 17 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/fix_reversediff branch March 16, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants