-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tests for Enzyme frontend for nonlinear problem #1066
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1066 +/- ##
===========================================
- Coverage 60.03% 37.23% -22.80%
===========================================
Files 19 19
Lines 4586 4496 -90
===========================================
- Hits 2753 1674 -1079
- Misses 1833 2822 +989 ☔ View full report in Codecov by Sentry. |
Where is this at? |
I made the change to not use a closure put pass all the arguments to autodiff. I included the tests for all the cases that we included previously with Zygote but not all of them pass (the commented ones). The uncommented tests with Enzyme should pass |
I mean, what needs to review and merge first? |
First SciML/SimpleNonlinearSolve.jl#151, then this should be ready. |
Add tests for SciML/NonlinearSolve.jl#439