Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for Enzyme frontend for nonlinear problem #1066

Merged
merged 21 commits into from
Jul 21, 2024

Conversation

m-bossart
Copy link
Contributor

test/steady_state.jl Outdated Show resolved Hide resolved
@m-bossart m-bossart marked this pull request as ready for review June 10, 2024 15:10
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.23%. Comparing base (8dd3bdf) to head (e9d8786).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1066       +/-   ##
===========================================
- Coverage   60.03%   37.23%   -22.80%     
===========================================
  Files          19       19               
  Lines        4586     4496       -90     
===========================================
- Hits         2753     1674     -1079     
- Misses       1833     2822      +989     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Where is this at?

@m-bossart
Copy link
Contributor Author

I made the change to not use a closure put pass all the arguments to autodiff. I included the tests for all the cases that we included previously with Zygote but not all of them pass (the commented ones). The uncommented tests with Enzyme should pass

@ChrisRackauckas
Copy link
Member

I mean, what needs to review and merge first?

@m-bossart
Copy link
Contributor Author

First SciML/SimpleNonlinearSolve.jl#151, then this should be ready.

Project.toml Outdated Show resolved Hide resolved
@ChrisRackauckas ChrisRackauckas merged commit b9a5a9e into SciML:master Jul 21, 2024
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants