-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SparseDiffTools v2 for steadystateadjoint #808
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d31d4cf
bump sparsedifftools
vpuri3 c872e14
get_autodiff_from_vjp
vpuri3 bca0805
(1) branch on has_adjoint, (2) rm fixedjacvecop, (3) replace with VecJac
vpuri3 693f487
Merge branch 'master' into scimlops
vpuri3 cb30f44
adtypes dep
vpuri3 b62e070
Merge branch 'master' into scimlops
vpuri3 a0f217b
bump sparsedifftools compat
vpuri3 9f06515
fix typo
vpuri3 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,7 @@ authors = ["Christopher Rackauckas <[email protected]>", "Yingbo Ma < | |
version = "7.37.0" | ||
|
||
[deps] | ||
ADTypes = "47edcb42-4c32-4615-8424-f2b9edc5f35b" | ||
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e" | ||
ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9" | ||
Cassette = "7057c7e9-c182-5462-911a-8362d720325c" | ||
|
@@ -71,7 +72,7 @@ ReverseDiff = "1.9" | |
SciMLBase = "1.66.0" | ||
SciMLOperators = "0.1, 0.2, 0.3" | ||
SimpleNonlinearSolve = "0.1.8" | ||
SparseDiffTools = "2" | ||
SparseDiffTools = "2.4" | ||
StaticArraysCore = "1.4" | ||
StochasticDiffEq = "6.20" | ||
Tracker = "0.2" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not really equivalent. IIRC
VecJac
recomputes the pullback everytime a call tomul!
is made. In this case, we have a fixed input, only the seeding changes so we compute the pullback once and just reevaluate it multiple times.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually fixed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see JuliaDiff/SparseDiffTools.jl#245