Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steady State Adjoints for Non-Vector Parameters #913

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

avik-pal
Copy link
Member

#877 implements quite a few things. I realized it might be better to split it up. This PR implements:

  • linsolve_kwargs: which controls the keyword arguments for the internal linear solver
  • Parameters to NonlinearProblem can be Arbitrary Structures!
  • Added a file containing utilities for non-vector parameters. We will need it anyways for the Gauss Adjoint work!

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #913 (8ccac8b) into master (fde1523) will decrease coverage by 0.03%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##           master     #913      +/-   ##
==========================================
- Coverage   61.60%   61.57%   -0.03%     
==========================================
  Files          19       20       +1     
  Lines        4344     4362      +18     
==========================================
+ Hits         2676     2686      +10     
- Misses       1668     1676       +8     
Files Coverage Δ
src/SciMLSensitivity.jl 100.00% <ø> (ø)
src/steadystate_adjoint.jl 88.13% <85.71%> (ø)
src/derivative_wrappers.jl 90.19% <89.47%> (ø)
src/sensitivity_algorithms.jl 75.90% <50.00%> (-1.88%) ⬇️
src/parameters_handling.jl 25.00% <25.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit d3fc07d into master Oct 14, 2023
20 of 24 checks passed
@ChrisRackauckas ChrisRackauckas deleted the ap/ssadjoint_better2 branch October 14, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants