-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass shadow closure incase f is a closure #962
Merged
ChrisRackauckas
merged 18 commits into
SciML:master
from
ArbitRandomUser:enzyme_vjp_closure_fix
Dec 29, 2023
Merged
pass shadow closure incase f is a closure #962
ChrisRackauckas
merged 18 commits into
SciML:master
from
ArbitRandomUser:enzyme_vjp_closure_fix
Dec 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArbitRandomUser
changed the title
pass shaddow variables incase f is a closure
pass shadow closure incase f is a closure
Dec 27, 2023
ChrisRackauckas
force-pushed
the
enzyme_vjp_closure_fix
branch
from
December 28, 2023 01:16
404be32
to
4a8fe6c
Compare
Yeah the finite differencing error is high. This is the max difference between Calculus and ForwardDiff: julia> maximum(refdp - refdp2)
5.0608451903078056e-5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP ... will check these later
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
passing closures to enzyme require enzyme to have shadows for captured variables ,
Enzyme.make_zero
allows one to do the same.