Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try fixing the 2nd callback test set #971

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Try fixing the 2nd callback test set #971

merged 2 commits into from
Jan 10, 2024

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@ChrisRackauckas
Copy link
Member Author

Looks like that was it, thanks.

@ChrisRackauckas ChrisRackauckas merged commit a0a8481 into master Jan 10, 2024
12 of 14 checks passed
@ChrisRackauckas ChrisRackauckas deleted the fixcallbacks branch January 10, 2024 15:31
@ChrisRackauckas
Copy link
Member Author

Note @acoh64 that we should probably do this with GaussAdjoint too since that is checkpointing.

@acoh64
Copy link
Contributor

acoh64 commented Jan 17, 2024

It looks like the change was in the one line of callback_tracking.jl. I can add a check for GaussAdjoint too. Were there any changes to how the checkpointing is done?

@ChrisRackauckas
Copy link
Member Author

Nope, no changes to checkpointing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisRackauckas @acoh64 @frankschae