-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] static array tests #288
base: master
Are you sure you want to change the base?
Conversation
test/static_array_tests.jl
Outdated
u0 = ones(MVector{2,Float64}) | ||
ode = SDEProblem(f, f, u0, (0.,1.)) | ||
sol = solve(ode, EM(), dt=1.e-2) | ||
sol = solve(ode, SRIW1()) | ||
sol = solve(ode, DRI1(), dt=1.e-2) | ||
|
||
u0 = ones(SVector{2,Float64}) | ||
f(u,p,t) = u | ||
prob = SDEProblem(f, f, u0, (0.,1.)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's calling the wrong f
.
test/static_array_tests.jl
Outdated
u0 = ones(MVector{2,Float64}) | ||
ode = SDEProblem(f, f, u0, (0.,1.)) | ||
sol = solve(ode, EM(), dt=1.e-2) | ||
sol = solve(ode, SRIW1()) | ||
sol = solve(ode, DRI1(), dt=1.e-2) | ||
|
||
u0 = ones(SVector{2,Float64}) | ||
f(u,p,t) = u | ||
prob = SDEProblem(f, f, u0, (0.,1.)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prob = SDEProblem(f, f, u0, (0.,1.)) | |
prob = SDEProblem{false}(f, f, u0, (0.,1.)) |
I had to remove the type fixes (They caused an error: |
that's likely because the wrong method was being called. Just do the normal StaticArrays: we should remove the arrays of arrays versions since with v1.0 they aren't possible to do in a sane way. |
I think that there is a problem with the static array tests. "ode" instead of "prob" was used, so SVector didn't actually work yet.
Should this be fixed by modifying
calculate_step!(W::NoiseProcess,dt)
inDiffEqNoiseProcess
?Here is the stack trace: