Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Ihat2 matrix from weak solvers #428

Merged
merged 4 commits into from
Jul 27, 2021
Merged

Remove Ihat2 matrix from weak solvers #428

merged 4 commits into from
Jul 27, 2021

Conversation

frankschae
Copy link
Member

see #427

NON2 is the only method that doesn't exclusively access individual elements of the matrix Ihat2 but instead it also contains matmuls of g with rows of Ihat2.

ChrisRackauckas
ChrisRackauckas approved these changes Jul 27, 2021
View reviewed changes
Copy link
Member

@ChrisRackauckas ChrisRackauckas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is better for GPUs too. Nice.

@frankschae frankschae merged commit 7ff0ee4 into master Jul 27, 2021
@frankschae frankschae deleted the remove_Ihat2_matrix branch July 27, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankschae @ChrisRackauckas