Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make SOSRA incompatible with non diagonal noise #587

Closed
wants to merge 1 commit into from
Closed

make SOSRA incompatible with non diagonal noise #587

wants to merge 1 commit into from

Conversation

oameye
Copy link

@oameye oameye commented Oct 28, 2024

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

reolves #578. What about SRA?

ChrisRackauckas added a commit that referenced this pull request Oct 29, 2024
@ChrisRackauckas
Handle non-diagonal noise in out of place SRA
e4ed586 
Fixes #578. All of the other convergence tests were in place but the non-diagonal case was just missing a few little bits.

Supersedes #587
@ChrisRackauckas ChrisRackauckas mentioned this pull request Oct 29, 2024
Merged
@ChrisRackauckas
Copy link
Member

Not needed due to the fix in #588

@oameye
Copy link
Author

oameye commented Oct 29, 2024

Cool :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oameye @ChrisRackauckas