Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being more concise in logging #230

Merged
merged 1 commit into from
Nov 5, 2023
Merged

Being more concise in logging #230

merged 1 commit into from
Nov 5, 2023

Conversation

sumiya11
Copy link
Collaborator

@sumiya11 sumiya11 commented Nov 5, 2023

Currently:

StructuralIdentifiability.assess_identifiability(ode)
[ Info: Assessing local identifiability
[ Info: Local identifiability assessed in 5.2702728 seconds
[ Info: Assessing global identifiability
[ Info: Note: the input model has nontrivial submodels. If the computation for the full model will be too heavy, you may want to try to first analyze one of the submodels. They can be produced using function find_submodels
[ Info: Functions to check involve states
[ Info: Computing IO-equations
┌ Info: Computed in 6.4942927 seconds
│   :ioeq_time = :ioeq_time
└   ioeq_time = 6.4942927
[ Info: Computing Wronskians
┌ Info: Computed in 2.5463854 seconds
│   :wrnsk_time = :wrnsk_time
└   wrnsk_time = 2.5463854
[ Info: Dimensions of the Wronskians [2]
┌ Info: Ranks of the Wronskians computed in 0.0258805 seconds
│   :rank_time = :rank_time
└   rank_times = 0.0258805
[ Info: Simplifying generating set
┌ Info: Computing normal forms (probabilistic)
│ Variables (3 in total): Nemo.QQMPolyRingElem[a, b, c]
│ Up to degree: 2
└ Modulo: Finite field of characteristic 1073741827
[ Info: Used specialization points: 2
[ Info: Computing 4 Groebner bases for block orderings. Simplification code is 1 
┌ Info: Final cleaning and simplification of generators. 
└ Out of 7 fractions 1 are syntactically unique.
[ Info: Checking inclusion with probability 0.991
[ Info: Inclusion checked in 3.9441141 seconds. Result: true
[ Info: Out of 2 initial generators there are 1 indepdendent
[ Info: The ranking of the new set of generators is 1
[ Info: Global identifiability assessed in 52.8739035 seconds

This PR:

StructuralIdentifiability.assess_identifiability(ode)
[ Info: Assessing local identifiability
[ Info: Local identifiability assessed in 0.0036979 seconds
[ Info: Assessing global identifiability
[ Info: Note: the input model has nontrivial submodels. If the computation for the full model will be too heavy, you may want to try to first analyze one of the submodels. They can be produced using function `find_submodels`
[ Info: Functions to check involve states
[ Info: Computing IO-equations
[ Info: Computed IO-equations in 0.003541 seconds
[ Info: Computing Wronskians
[ Info: Computed Wronskians in 0.001314 seconds
[ Info: Dimensions of the Wronskians [2]
[ Info: Ranks of the Wronskians computed in 3.51e-5 seconds
[ Info: Simplifying generating set. Simplification level: standard
[ Info: Computing normal forms of degree 2 in 3 variables
[ Info: Used 2 specializations in 0.0028098 seconds, found 1 relations
[ Info: Computing 4 Groebner bases for degrees (3, 3) for block orderings        
[ Info: Computed Groebner bases in 0.0281257 seconds
[ Info: Inclusion checked with probability 0.991 in 0.0007177 seconds
[ Info: Global identifiability assessed in 0.054335 seconds

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #230 (6f864ff) into master (88754c7) will increase coverage by 0.07%.
Report is 2 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   90.80%   90.87%   +0.07%     
==========================================
  Files          24       24              
  Lines        3143     3146       +3     
==========================================
+ Hits         2854     2859       +5     
+ Misses        289      287       -2     
Files Coverage Δ
...rc/RationalFunctionFields/RationalFunctionField.jl 89.76% <100.00%> (+0.03%) ⬆️
src/RationalFunctionFields/normalforms.jl 97.66% <100.00%> (+0.41%) ⬆️
src/global_identifiability.jl 87.00% <100.00%> (-1.00%) ⬇️

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@pogudingleb pogudingleb merged commit 790a655 into master Nov 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants