Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression of a function in terms of generators of rational function field (bug fix) #308

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

pogudingleb
Copy link
Collaborator

Alexey Ovchinnikov has reported the failure of an assertion during reparametrization on

ode = @ODEmodel(
    x'(t) = b * (x(t)^2 + 1) / (2 * a),
    y(t) = 2 * x(t) / (b * (1 + x(t)^2))
)

The problem was with computing the expressions of rational function wrt the tag variables, it is fixed.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.09%. Comparing base (08dabc1) to head (e471b8c).
Report is 2 commits behind head on master.

Files Patch % Lines
src/util.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   90.04%   90.09%   +0.05%     
==========================================
  Files          28       28              
  Lines        3306     3313       +7     
==========================================
+ Hits         2977     2985       +8     
+ Misses        329      328       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pogudingleb pogudingleb merged commit cba6249 into master Apr 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant