make the saveat and tstop handling match OrdinaryDiffEq more closely #436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove bug where we would pretend to hit
tstops
when not actually doing so. Specifically, the check ofwhile integrator.tdir * (integrator.t - first(integrator.opts.tstops)) < -1e6eps()
meant that tstops would be ignored if the solver happened to be close to the time that the solver happened to step. I'm not 100% sure that the issue the comment was warning about is gone (partly because the comment appears to have been cut off in the middle), but I suspect that theif integrator.t == integrator.tprev
check that I added a few months ago may have fixed it.