Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix saveat includes save_start for ARKODE #461

Merged
merged 10 commits into from
Oct 11, 2024

Conversation

oscardssmith
Copy link
Contributor

fixes #460

@oscardssmith
Copy link
Contributor Author

@ChrisRackauckas any idea what's up with CI?

@ChrisRackauckas
Copy link
Member

Replace that dep with https://github.com/adrhill/SparseConnectivityTracer.jl

@oscardssmith
Copy link
Contributor Author

@ChrisRackauckas why did you undo my jacvec changes that were fixing the sparsediff error?

@ChrisRackauckas
Copy link
Member

I thought they were leading to the JacVec error. Then what's the JacVec error?

@ChrisRackauckas
Copy link
Member

did it pass on LTS?

@oscardssmith
Copy link
Contributor Author

no, but I think now it will.

@oscardssmith oscardssmith merged commit 52677f8 into SciML:master Oct 11, 2024
1 of 3 checks passed
@oscardssmith oscardssmith deleted the os/fix-ARKODE-saveat branch October 11, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

saveat includes save_start and save_end for ARKODE() but not for others
2 participants