fix: ignore symbols in remake_buffer which aren't variables or para…

…meters
SciML · Sep 2, 2024 · c0d8cd1 · c0d8cd1
1 parent e8c5c23
commit c0d8cd1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/remake.jl b/src/remake.jl
@@ -40,6 +40,7 @@ function remake_buffer(sys, oldbuffer::AbstractArray, idxs, vals)
         newbuffer = similar(oldbuffer, elT)
         copyto!(newbuffer, oldbuffer)
         for (k, v) in zip(idxs, vals)
+            is_variable(sys, k) || is_parameter(sys, k) || continue
             if v isa AbstractArray
                 v = elT.(v)
             else

diff --git a/test/remake_test.jl b/test/remake_test.jl
@@ -19,7 +19,9 @@ for (buf, newbuf, idxs, vals) in [
     # buffer type promotion
     ([1, 2, 3], [2.0, 2.0, 3.0], [:a], [2.0]),
     # value type promotion
-    ([1, 2, 3], [2, 3.0, 4.0], [:a, :b, :c], Real[2, 3.0, 4.0])
+    ([1, 2, 3], [2, 3.0, 4.0], [:a, :b, :c], Real[2, 3.0, 4.0]),
+    # skip non-parameters
+    ([1, 2, 3], [2.0, 3.0, 3.0], [:a, :b, :(a + b)], [2.0, 3.0, 5.0])
 ]
     for arrType in [Vector, SVector{3}, MVector{3}, SizedVector{3}]
         buf = arrType(buf)
@@ -49,7 +51,9 @@ for (buf, newbuf, idxs, vals) in [
     # buffer type promotion
     ((1, 2, 3), (2.0, 3.0, 4.0), [:x, :y, :z], [2.0, 3.0, 4.0]),
     # value type promotion
-    ((1, 2, 3), (2, 3.0, 4.0), [:x, :y, :z], Real[2, 3.0, 4.0])
+    ((1, 2, 3), (2, 3.0, 4.0), [:x, :y, :z], Real[2, 3.0, 4.0]),
+    # skip non-variables
+    ([1, 2, 3], [2.0, 3.0, 3.0], [:x, :y, :(x + y)], [2.0, 3.0, 5.0])
 ]
     _newbuf = remake_buffer(sys, buf, idxs, vals)
     @test newbuf == _newbuf # test values