Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add IsTimeseriesTrait, support timeseries objects in getu #25

Merged
merged 4 commits into from
Jan 2, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (9c5e3b5) 0.00% compared to head (29d692b) 24.85%.

Files Patch % Lines
src/state_indexing.jl 0.00% 30 Missing ⚠️
src/parameter_indexing.jl 60.00% 2 Missing ⚠️
src/symbol_cache.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #25       +/-   ##
===========================================
+ Coverage    0.00%   24.85%   +24.85%     
===========================================
  Files           5        6        +1     
  Lines         150      177       +27     
===========================================
+ Hits            0       44       +44     
+ Misses        150      133       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit 4da53e6 into master Jan 2, 2024
11 checks passed
@ChrisRackauckas ChrisRackauckas deleted the as/getu-sol branch January 2, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants