Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make getp generic of the parameter container #42

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b6bbb66) 25.33% compared to head (599575d) 25.87%.

Files Patch % Lines
src/parameter_indexing.jl 85.71% 1 Missing ⚠️
src/state_indexing.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   25.33%   25.87%   +0.54%     
==========================================
  Files           7        7              
  Lines         225      228       +3     
==========================================
+ Hits           57       59       +2     
- Misses        168      169       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal AayushSabharwal force-pushed the as/getp-generic branch 4 times, most recently from 20719c5 to 1c5ebf7 Compare February 13, 2024 10:17
@ChrisRackauckas ChrisRackauckas merged commit ccbfdc5 into master Feb 14, 2024
11 checks passed
@ChrisRackauckas ChrisRackauckas deleted the as/getp-generic branch February 14, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants