Feature/tweak actions #1507
Merged
Feature/tweak actions #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ec11e56 in 22 seconds
More details
- Looked at
159lines of code in7files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. .github/workflows/r2r-full-py-integration-tests.yml:59
- Draft comment:
Usingcontinue-on-error: truecan cause tests to fail silently. Ensure this is intentional and understood by the team. This applies to other similar lines in this file and other workflow files. - Reason this comment was not posted:
Confidence changes required:50%
Thecontinue-on-error: truedirective is used in multiple places in the workflow files. This can lead to tests failing silently, which might not be the desired behavior. It's important to ensure that this is intentional and that the team is aware of the potential for silent failures.
2. .github/workflows/r2r-full-py-integration-tests-mac-and-windows.yml:4
- Draft comment:
Thepushevent trigger has been removed. Ensure this aligns with the intended CI/CD strategy. This also applies to ther2r-light-py-integration-tests-mac-and-windows.ymlfile. - Reason this comment was not posted:
Confidence changes required:50%
Thepushevent trigger has been removed from ther2r-full-py-integration-tests-mac-and-windows.ymlandr2r-light-py-integration-tests-mac-and-windows.ymlfiles. This means these workflows will only run when manually triggered. Ensure this change aligns with the intended CI/CD strategy.
3. py/tests/integration/runner_sdk.py:589
- Draft comment:
The comment about testing for a duplicate user might be misleading as the login email used is[email protected]. Clarify or correct this comment. - Reason this comment was not posted:
Confidence changes required:50%
Thetest_user_password_managementfunction has a comment indicating a test for a duplicate user, but the login email used is[email protected]. This might be misleading and should be clarified or corrected.
Workflow ID: wflow_DBIgxLeJUdGQM52j
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
emrgnt-cmplxty
added a commit
that referenced
this pull request
Oct 28, 2024
* Feature/tweak actions (#1507) * up * tweak actions * adding bin sup and making it default * tested and vetted
Merged
emrgnt-cmplxty
added a commit
that referenced
this pull request
Oct 28, 2024
* Feature/tweak actions (#1507) * up * tweak actions * modify exp backoff impl --------- Co-authored-by: emrgnt-cmplxty <[email protected]>
emrgnt-cmplxty
added a commit
that referenced
this pull request
Oct 30, 2024
* Feature/tweak actions (#1507) * up * tweak actions * Sync JS SDK, Harmonize Python SDK KG Methods (#1511) * Feature/move logging (#1492) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) * Feature/dev rebased (#1500) * Feature/move logging (#1493) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * Update js package (#1498) * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) --------- Co-authored-by: Nolan Tremelling <[email protected]> * Fix handling for R2R exceptions (#1501) * fix doc test (#1502) * Harmonize python SDK KG methods for optional params, add missing JS methods --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: emrgnt-cmplxty <[email protected]> * Clean up pagination and offset around KG (#1519) * Move to R2R light for integration testing (#1521) * Update community model --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: emrgnt-cmplxty <[email protected]>
emrgnt-cmplxty
added a commit
that referenced
this pull request
Oct 30, 2024
* Feature/tweak actions (#1507) * up * tweak actions * Sync JS SDK, Harmonize Python SDK KG Methods (#1511) * Feature/move logging (#1492) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) * Feature/dev rebased (#1500) * Feature/move logging (#1493) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * Update js package (#1498) * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) --------- Co-authored-by: Nolan Tremelling <[email protected]> * Fix handling for R2R exceptions (#1501) * fix doc test (#1502) * Harmonize python SDK KG methods for optional params, add missing JS methods --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: emrgnt-cmplxty <[email protected]> * Clean up pagination and offset around KG (#1519) * Move to R2R light for integration testing (#1521) --------- Co-authored-by: Nolan Tremelling <[email protected]>
emrgnt-cmplxty
added a commit
that referenced
this pull request
Oct 30, 2024
* Feature/tweak actions (#1507) * up * tweak actions * Sync JS SDK, Harmonize Python SDK KG Methods (#1511) * Feature/move logging (#1492) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) * Feature/dev rebased (#1500) * Feature/move logging (#1493) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * Update js package (#1498) * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) --------- Co-authored-by: Nolan Tremelling <[email protected]> * Fix handling for R2R exceptions (#1501) * fix doc test (#1502) * Harmonize python SDK KG methods for optional params, add missing JS methods --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: emrgnt-cmplxty <[email protected]> * Clean up pagination and offset around KG (#1519) * Move to R2R light for integration testing (#1521) * fix ollama pdf parser --------- Co-authored-by: Nolan Tremelling <[email protected]>
emrgnt-cmplxty
added a commit
that referenced
this pull request
Oct 30, 2024
* adding bin support and make it default (#1508) * Feature/tweak actions (#1507) * up * tweak actions * adding bin sup and making it default * tested and vetted * up (#1510) * up * set verification to default false * cleanup (#1512) * cleanup * cleanup prompt mgmt * up * cleanup printout * cleanup new parser logic, set vlm as default for all providers * allow user to re-override * modify exp backoff implementation (#1513) * Feature/tweak actions (#1507) * up * tweak actions * modify exp backoff impl --------- Co-authored-by: emrgnt-cmplxty <[email protected]> * Patch/touchups (#1515) * cleanup * cleanup prompt mgmt * up * cleanup printout * cleanup new parser logic, set vlm as default for all providers * allow user to re-override * add touchups * add extra parsers (#1516) * add extra parsers (#1518) * minor fixes (#1514) * Feature/add back ollama provider (#1522) * add extra parsers * add back ollama * rvert auth workflow * Feature/add prompt tests and cleanup (#1523) * add extra parsers * add prompt tests, cleanup * add prompt tests, cleanup * merge * set mock console as default * set mock console as default * fix config * Update community model (#1524) * Feature/tweak actions (#1507) * up * tweak actions * Sync JS SDK, Harmonize Python SDK KG Methods (#1511) * Feature/move logging (#1492) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) * Feature/dev rebased (#1500) * Feature/move logging (#1493) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * Update js package (#1498) * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) --------- Co-authored-by: Nolan Tremelling <[email protected]> * Fix handling for R2R exceptions (#1501) * fix doc test (#1502) * Harmonize python SDK KG methods for optional params, add missing JS methods --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: emrgnt-cmplxty <[email protected]> * Clean up pagination and offset around KG (#1519) * Move to R2R light for integration testing (#1521) * Update community model --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: emrgnt-cmplxty <[email protected]> * Patch/fix import bleed (#1526) * Feature/tweak actions (#1507) * up * tweak actions * Sync JS SDK, Harmonize Python SDK KG Methods (#1511) * Feature/move logging (#1492) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) * Feature/dev rebased (#1500) * Feature/move logging (#1493) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * Update js package (#1498) * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) --------- Co-authored-by: Nolan Tremelling <[email protected]> * Fix handling for R2R exceptions (#1501) * fix doc test (#1502) * Harmonize python SDK KG methods for optional params, add missing JS methods --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: emrgnt-cmplxty <[email protected]> * Clean up pagination and offset around KG (#1519) * Move to R2R light for integration testing (#1521) --------- Co-authored-by: Nolan Tremelling <[email protected]> * Patch/fix import bleed (#1527) * Feature/tweak actions (#1507) * up * tweak actions * Sync JS SDK, Harmonize Python SDK KG Methods (#1511) * Feature/move logging (#1492) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) * Feature/dev rebased (#1500) * Feature/move logging (#1493) * move logging provider out * move logging provider to own directory, remove singleton * cleanup * Update js package (#1498) * fix refactoring tweak (#1496) * Fix JSON serialization and Prompt ID Bugs for Prompts (#1491) * Bug in get prompts * Add tests * Prevent verbose logging on standup * Remove kg as required key in config, await get_all_prompts * Remove reference to fragment id * comment out ingestion * complete logging port (#1499) --------- Co-authored-by: Nolan Tremelling <[email protected]> * Fix handling for R2R exceptions (#1501) * fix doc test (#1502) * Harmonize python SDK KG methods for optional params, add missing JS methods --------- Co-authored-by: emrgnt-cmplxty <[email protected]> Co-authored-by: emrgnt-cmplxty <[email protected]> * Clean up pagination and offset around KG (#1519) * Move to R2R light for integration testing (#1521) * fix ollama pdf parser --------- Co-authored-by: Nolan Tremelling <[email protected]> * email auth false and js bump * fix actions (#1528) * Feature/add poppler check and fallback (#1529) * fix actions * fallback * Patch/import shutil (#1530) * fix actions * fallback * import shutil * Feature/include basic pdf parsing everywhere (#1531) * fix actions * fallback * import shutil * add basic pdf as extra parser in all configs * Remove non existent user login? * attempt login * Change password back * add explicit setting, trigger rebuild --------- Co-authored-by: Shreyas Pimpalgaonkar <[email protected]> Co-authored-by: Nolan Tremelling <[email protected]>
NolanTrem
pushed a commit
that referenced
this pull request
Oct 31, 2024
* minor fixes * up * adding bin support and make it default (#1508) * Feature/tweak actions (#1507) * up * tweak actions * adding bin sup and making it default * tested and vetted * up (#1510) * up * set verification to default false * up * cleanup (#1512) * cleanup * cleanup prompt mgmt * up * cleanup printout * cleanup new parser logic, set vlm as default for all providers * allow user to re-override * cleanup; pre-commit * rm launch json * checkin work * up * modify endpoint * up --------- Co-authored-by: emrgnt-cmplxty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR updates GitHub Actions workflows to include the 'main' branch and modifies a test email in
runner_sdk.py.r2r-full-py-integration-tests-graphrag.yml,r2r-full-py-integration-tests.yml, andr2r-light-py-integration-tests-graphrag.yml.r2r-full-py-integration-tests-mac-and-windows.ymlandr2r-light-py-integration-tests-mac-and-windows.yml.continue-on-error: trueto test steps inr2r-full-py-integration-tests.ymlandr2r-light-py-integration-tests.yml.test_user_password_management()inrunner_sdk.pyfrom[email protected]to[email protected].This description was created by
for ec11e56. It will automatically update as commits are pushed.